CI-CD for domains #1318
Merged
CI-CD for domains #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Jan 17, 2025
saliceti
reviewed
Jan 17, 2025
saliceti
reviewed
Jan 17, 2025
saliceti
reviewed
Jan 20, 2025
neillturner
force-pushed
the
ci-cd-domains2
branch
2 times, most recently
from
0359a88 to
83d555f
Compare
neillturner
force-pushed
the
ci-cd-domains2
branch
from
83d555f to
bbb6f84
Compare
shaheislamdfe
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
adding workflows for domain deployment to build workflows
Changes proposed in this pull request
this is the updated deploy.yml adding calls to the deploy domains github actions.
Guidance to review
review the actions to see the workflows being running.
review code and decide on best architecture
can see test runs for jobs added to deploy.yml run as separate test runs but doing plan not apply
https://github.com/DFE-Digital/itt-mentor-services/actions/runs/12829975027
https://github.com/DFE-Digital/itt-mentor-services/actions/runs/12829975022 (this only fails because plan doesn't see output variable like apply so will success for apply)
Link to Trello card
Implement CI/CD for domains on all services