Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edit claim to wizard pattern #1212

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • To improve the efficiency of Editing a Claim. Refactor the Edit Claim journey to use the Wizard pattern.

Changes proposed in this pull request

  • Introduce EditClaimWizard and related steps
  • Remove code with is no longer necessary
  • Add test coverage to ensure all code changes have been tested.
  • ... success?

Guidance to review

Sign in as Anne (School user)

  • Visit the show page for an existing DRAFT claim

  • Edit an existing claim (provider, mentors, mentor training hours)
  • Submit the claim -> The existing claim should be updated and submitted.

  • Click "Submit claim"
  • You should be redirected to the Declaration page.
  • Click "Submit claim" -> The existing clam should be submitted

Sign in as Colin (Support user)

  • Visit the show page for an existing DRAFT claim
  • Edit an existing claim (provider, mentors, mentor training hours)
  • Submit the claim -> The existing claim should be updated and submitted.

Link to Trello card

https://trello.com/c/dzMquW8D/934-refactor-the-edit-claim-form-to-use-the-wizard-pattern

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Nov 28, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Nov 28, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners November 28, 2024 16:32
@JamieCleare2525 JamieCleare2525 changed the base branch from main to jc/refactor_claims_to_wizard_pattern November 28, 2024 16:32
Copy link

@JamieCleare2525 JamieCleare2525 force-pushed the jc/refactor_edit_claim_to_wizard_pattern branch from b77f405 to 07117e5 Compare February 5, 2025 11:05
@JamieCleare2525 JamieCleare2525 merged commit ac78b62 into jc/refactor_claims_to_wizard_pattern Feb 10, 2025
10 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/refactor_edit_claim_to_wizard_pattern branch February 10, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants