-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor edit placement system specs #1180
Conversation
5debf8c
to
d66ab31
Compare
ea34b2f
to
45e287b
Compare
e4d1ffc
to
7c67fb9
Compare
spec/system/placements/schools/placements/school_user_edits_a_placement_with_no_mentors_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/placements/school_user_edits_a_placement_with_no_mentors_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/placements/secondary_school_user_edits_a_placement_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/placements/secondary_school_user_edits_a_placement_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/placements/secondary_school_user_edits_a_placement_spec.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, because pages just the check your answers, show, preview, etc. contain the same information, it's worth adding a current_path
to steps checking the page you are on.
83ab9fb
to
d4039ad
Compare
d4039ad
to
99acb04
Compare
All of these pages are unique when you factor in the headings, page titles and selected navigation so there's no risk of us falsely identifying the wrong page. A user generally doesn't care about the URL of the page so long as they're being shown what they expect to be shown, so I do not think of it as a user need and therefore it's not a responsibility of our system specs. I also don't want to tie our system specs to certain routes in case we need to change those routes in the future, we would have broken tests that still offer the same user journey and therefore should not be breaking. |
Context
We have agreed as a team that we'd like to pursue a new style of system specs to bring our organically (home baked) system specs in line and identify any gaps in their testing.
Changes proposed in this pull request
Guidance to review
Link to Trello card
Refactor edit placement system tests