Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edit placement system specs #1180

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Nov 14, 2024

Context

We have agreed as a team that we'd like to pursue a new style of system specs to bring our organically (home baked) system specs in line and identify any gaps in their testing.

Changes proposed in this pull request

  • Adds a system spec for a school user editing a placement for a primary school
  • Adds a system spec for a school user editing a placement for a secondary school
  • Adds a system spec for a school user editing a placement with no mentors
  • Adds a system spec for a school user editing a placement with no providers
  • Adds a system spec for a support user editing a placement for a primary school
  • Adds a system spec for a support user editing a placement for a secondary school
  • Adds a system spec for a support user editing a placement with no mentors
  • Adds a system spec for a support user editing a placement with no providers
  • Removes redundant edit placement spec for school users
  • Removes redundant edit placement spec for support users
  • Adds govuk tag matcher

Guidance to review

  • Review the spec files and look for any missed scenarios or elements that are important to an end user.

Link to Trello card

Refactor edit placement system tests

@Kizr Kizr self-assigned this Nov 14, 2024
@Kizr Kizr force-pushed the ba/refactor-edit-placement-system-specs branch from 5debf8c to d66ab31 Compare November 20, 2024 12:29
@Kizr Kizr marked this pull request as ready for review November 20, 2024 12:38
@Kizr Kizr requested review from a team as code owners November 20, 2024 12:38
@Kizr Kizr force-pushed the ba/refactor-edit-placement-system-specs branch from ea34b2f to 45e287b Compare November 20, 2024 12:39
@Kizr Kizr changed the title Create spec for a primary school user editing a placement Refactor edit placement system specs Nov 20, 2024
@Kizr Kizr force-pushed the ba/refactor-edit-placement-system-specs branch 2 times, most recently from e4d1ffc to 7c67fb9 Compare November 22, 2024 13:00
Copy link
Contributor

@JamieCleare2525 JamieCleare2525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, because pages just the check your answers, show, preview, etc. contain the same information, it's worth adding a current_path to steps checking the page you are on.

@Kizr Kizr force-pushed the ba/refactor-edit-placement-system-specs branch 2 times, most recently from 83ab9fb to d4039ad Compare November 25, 2024 14:30
@Kizr Kizr force-pushed the ba/refactor-edit-placement-system-specs branch from d4039ad to 99acb04 Compare November 25, 2024 14:31
@Kizr
Copy link
Contributor Author

Kizr commented Nov 26, 2024

I think, because pages just the check your answers, show, preview, etc. contain the same information, it's worth adding a current_path to steps checking the page you are on.

All of these pages are unique when you factor in the headings, page titles and selected navigation so there's no risk of us falsely identifying the wrong page.

A user generally doesn't care about the URL of the page so long as they're being shown what they expect to be shown, so I do not think of it as a user need and therefore it's not a responsibility of our system specs.

I also don't want to tie our system specs to certain routes in case we need to change those routes in the future, we would have broken tests that still offer the same user journey and therefore should not be breaking.

@Kizr Kizr enabled auto-merge (rebase) November 29, 2024 10:08
@Kizr Kizr merged commit e09fa12 into main Nov 29, 2024
8 checks passed
@Kizr Kizr deleted the ba/refactor-edit-placement-system-specs branch November 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants