So/review sentry exception logging in the api #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spanersoraferty
temporarily deployed
to
development_aks
GitHub Actions
Inactive
github-actions
bot
added
VisualCSharp
martyn-w
reviewed
Jan 29, 2025
martyn-w
reviewed
Jan 29, 2025
GetIntoTeachingApi/appsettings.json
Outdated
| @@ -10,9 +10,18 @@ | |||
| "WriteTo": [ | |||
| { | |||
| "Name": "Console" | |||
| }, | |||
| { | |||
| "Name": "File", | |||
There was a problem hiding this comment.
could this be a local dev setting, rather than in the main app settings? I don't think this will work on production
There was a problem hiding this comment.
Actually, this should be removed. Thought I had, leave it with me and I'll sort.
|
martyn-w
approved these changes
Feb 4, 2025
spanersoraferty
deleted the
SO/review-sentry-exception-logging-in-the-API
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've limited the use of the correlation ID to the teacher advisor sign-up endpoint (as discussed) to limit the potential for issues if any problems occur. I've also not been able to best the filter attribute, it is possible but I cannot mock the hangfire context because they've neglected to apply interfaces, or make class methods generic. We could use a library like Typemock but not sure if this will play nicely with the CICD pipeline out of the box.
If theses changes prove stable we can raise a second, follow-on ticket to complete the work to apply this logging behaviour across the remaining endpoints.