Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transaction tests #186

Merged
merged 1 commit into from
Dec 17, 2024
Merged

update transaction tests #186

merged 1 commit into from
Dec 17, 2024

Conversation

goodviber
Copy link
Contributor

The transaction rollback tests seem to have been incorrectly configured, calling a create action outside of the transaction block, which results in a send event even when the block is rolled back.

@goodviber goodviber added the bug Something isn't working label Dec 16, 2024
@goodviber goodviber requested a review from asatwal December 16, 2024 08:50
@goodviber goodviber self-assigned this Dec 16, 2024
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@goodviber goodviber merged commit 95fae17 into main Dec 17, 2024
5 checks passed
@goodviber goodviber deleted the apply-issue branch December 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants