Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.3 #171

Merged
merged 16 commits into from
Nov 8, 2024
Merged

Update 3.3 #171

merged 16 commits into from
Nov 8, 2024

Conversation

goodviber
Copy link
Contributor

@goodviber goodviber commented Nov 8, 2024

Register and some other services are upgrading to Ruby 3.3.

Register PR here

We need update the DfE Analytics workflow. For example like this PR

This PR runs the specs in ruby [3.2, 3.3] and rails [7.1, 7.2], rubocop is set at 3.3, we can change this as required

@goodviber goodviber requested review from defong and asatwal November 8, 2024 15:19
@goodviber goodviber self-assigned this Nov 8, 2024
@goodviber goodviber added the enhancement New feature or request label Nov 8, 2024
@goodviber
Copy link
Contributor Author

Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@goodviber goodviber merged commit bdf2a9a into main Nov 8, 2024
5 checks passed
@goodviber goodviber deleted the update-3.3 branch November 8, 2024 16:44
asatwal pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants