Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect sign in page #444

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Redirect sign in page #444

merged 1 commit into from
Jan 20, 2025

Conversation

richardpattinson
Copy link
Contributor

@richardpattinson richardpattinson commented Jan 10, 2025

Context

There is a request to make the guidance page the start page.

Navigating to the service should redirect the user to the sign page
without having to press the Start now button again.

I considered updating the guidance page and making the POST request from
there.

This introduces a longer development cycle and makes it slower to make
changes as another team has to be involved.

Instead, I opted to contain the change within this service. There is a
library called repost that can help us here.

It allows us to do a POST redirect by rendering a form with the redirect
URL and auto-submits it.

This has the end result of doing a POST redirect.

Some limitations are that the redirect won't trigger when Javascript is
disabled.

Changes proposed in this pull request

Guidance to review

Link to Trello card

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch 6 times, most recently from 373d14d to ab74b12 Compare January 10, 2025 10:56
@richardpattinson richardpattinson added the deploy Deploys a review app label Jan 10, 2025
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 10:59 Destroyed
@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch 2 times, most recently from 5e22b80 to 14bf167 Compare January 10, 2025 11:36
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 11:37 Destroyed
@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch from 14bf167 to 1e322f1 Compare January 10, 2025 11:39
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 11:40 Destroyed
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 11:44 Destroyed
@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch from 1e322f1 to 2126d14 Compare January 10, 2025 11:50
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 11:54 Destroyed
@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch from 2126d14 to 0613e1b Compare January 10, 2025 13:47
@github-actions github-actions bot temporarily deployed to review-444 January 10, 2025 13:49 Destroyed
@richardpattinson richardpattinson force-pushed the redirect-from-start-page branch from 0613e1b to bfe5cfd Compare January 16, 2025 11:27
@github-actions github-actions bot temporarily deployed to review-444 January 16, 2025 11:29 Destroyed
@richardpattinson richardpattinson merged commit 443109c into main Jan 20, 2025
12 checks passed
@richardpattinson richardpattinson deleted the redirect-from-start-page branch January 20, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploys a review app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants