AKS Migration — deploy review apps #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
force-pushed
the
130-aks--deploy-review-apps
branch
2 times, most recently
from
5e8d927 to
e9c20a6
Compare
felixclack
force-pushed
the
130-aks--deploy-review-apps
branch
from
e9c20a6 to
2ca8f8e
Compare
richardpattinson
had a problem deploying
to
review
GitHub Actions
Failure
richardpattinson
force-pushed
the
130-aks--deploy-review-apps
branch
from
cad8465 to
576c543
Compare
richardpattinson
had a problem deploying
to
review
GitHub Actions
Failure
richardpattinson
force-pushed
the
130-aks--deploy-review-apps
branch
from
576c543 to
98e54a6
Compare
richardpattinson
had a problem deploying
to
review
GitHub Actions
Failure
richardpattinson
force-pushed
the
130-aks--deploy-review-apps
branch
from
98e54a6 to
6215665
Compare
richardpattinson
had a problem deploying
to
review
GitHub Actions
Failure
richardpattinson
approved these changes
Aug 6, 2024
It's useful to run the build even if we don't deploy to review. So we can use the image when deploying locally.
saliceti
force-pushed
the
130-aks--deploy-review-apps
branch
from
6ca6560 to
e362fb1
Compare
saliceti
force-pushed
the
130-aks--deploy-review-apps
branch
from
06a32f4 to
b573a84
Compare
RMcVelia
reviewed
Aug 15, 2024
saliceti
force-pushed
the
130-aks--deploy-review-apps
branch
from
b573a84 to
eef84ab
Compare
RMcVelia
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're going to migrate AYTQ/CTR to AKS.
Changes proposed in this pull request
This PR starts pulling together the files and configuration needed to manually deploy review apps to AKS.
It's a work-in-progress, opened as a draft PR for visibility and to hand over this work to @felixclack .
The resource group has been set up by @saliceti . The remaining work here can be driven out from:
make aks-review aks-terraform-plan PR_NUMBER=xxGuidance to review
Link to Trello card
https://trello.com/c/Ng21PrA6/130-start-aytq-aks-migration-by-completing-onboarding-form-and-generating-initial-code
https://trello.com/c/OUi4acsm/132-%F0%9F%94%A5epic-design-and-implement-ctr-bulk-search-feature-for-hei-tsa (Epic)
Checklist