Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open service #463

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Open service #463

merged 2 commits into from
Dec 6, 2023

Conversation

gpeng
Copy link
Contributor

@gpeng gpeng commented Dec 6, 2023

Context

Re-opening this after an aborted attempt to deploy it yesterday. We are splitting the feature flags to allow us to open AYTQ while keeping Check closed until launch.

Changes proposed in this pull request

  • Add extra feature flags per service
  • Remove the staff_http_basic_auth flag and strategy as these were only required to allow us to invite an initial staff user and we can't do that any more so this is just extra attack surface and complexity

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

felixclack and others added 2 commits December 6, 2023 12:11
We have a single feature flag controlling access to 3 different apps,
which makes releasing them separately impossible.

There is no reason for them to share a single feature flag so I'm
introducing 2 extra flags to give us the granularity we want.

Each service, Check + Quals, will have a unique feature flag to control
opening the service up to the public. Also, there is now a separate
feature flag for the support interface too.
This is uneccessary now that we are using DSI for support as it was only
used to allow an invitation to be sent for the first staff user.
@gpeng gpeng merged commit 67ac811 into main Dec 6, 2023
12 checks passed
@gpeng gpeng deleted the open-service branch December 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants