Add qualifications_service_open flag #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to add/remove basic auth from the AYTQ service only.
steventux
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to add/remove basic auth from the AYTQ service only. It currently isn't checked so this PR just adds it so as we can ensure the service stays open when we deploy the subsequent PR.
Context
We have a service_open feature flag that adds basic auth but we need to be able to do that separately for AYTQ (which is already live) and Check... This is the first PR in splitting the flags.
Changes proposed in this pull request
Add a, currently unused, qualifications_service_open feature flag.
Checklist