Add additional detail around 403s from Qualifications API #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
requested review from
gpeng,
felixclack and
steventux
and removed request for
gpeng
We haven't been handling 403 errors from the API, and are starting to see quite a few in production. It isn't currently clear what's causing these errors. This commit adds a local Sentry scope that extracts various pieces of information about the Identity session and sends it to Sentry whenever this error occurs. This should help us with debugging the issue.
malcolmbaig
force-pushed
the
1388-fix-quals-403-handling--2
branch
from
19d4f8d to
b63bf1b
Compare
gunndabad
approved these changes
Dec 5, 2023
gpeng
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We haven't been handling 403 errors from the API, and are starting to see quite a few in production. It isn't currently clear what's causing these errors.
Changes proposed in this pull request
This commit adds a local Sentry scope that extracts various pieces of information about the Identity session and sends it to Sentry whenever this error occurs. This should help us with debugging the issue.
Guidance to review
I've tested this by setting the Sentry DSN in local dev and manually triggering the
QualificationsApi::ForbiddenError.This results in the Sentry issue being tagged with the user id and the following section appearing further down:
@gunndabad fyi ^
Link to Trello card
https://trello.com/c/yFP3gVsr
Checklist