feat: add eventService and test #42
Conversation
| import {ContractFactoryModule} from '../web3/contract/contract.module'; | ||
|
|
||
| export const eventServiceProvider = { | ||
| provide: 'EVENT_SERVICE', |
There was a problem hiding this comment.
How about registering eventService at EventModule?
| export class EventModule {} | ||
| export const eventProvider = { | ||
| provide: 'EVENT', | ||
| useClass: Event, |
There was a problem hiding this comment.
Where this event is injected? I think its weired to make event as provider
| @Inject('ABI') private abi: AbiConfig) { | ||
| } | ||
|
|
||
| getInstance(eventType: EventList) { |
| NewToken: 'Auction', | ||
| }; | ||
|
|
||
| export enum EventList { |
| import {InjectConfig} from 'nestjs-config'; | ||
|
|
||
| @Injectable() | ||
| export class AbiConfig { |
There was a problem hiding this comment.
Is this config? I think abiService is better
| @@ -0,0 +1,3 @@ | |||
| export default { | |||
| abi: [], | |||
There was a problem hiding this comment.
Is this empty although it is not for test?
|
|
||
| service = module.get<EventService>(EventService); | ||
| }); | ||
| describe('check mockedContract', () => { |
|
|
||
| describe('#getEvents()', () => { | ||
| it('should return expectedEvent', async () => { | ||
| const module: TestingModule = await Test.createTestingModule({ |
There was a problem hiding this comment.
This part is being repeated. I think it can me minimized with beforeAll or beforeEach
| const testAddress = ''; | ||
| let mockedWeb3: Web3 = mock(Web3); | ||
| let mockedContract: Contract = mock(Contract); | ||
| let mockedEventService: EventService = mock(EventService); |
There was a problem hiding this comment.
U should not mock eventService when testing eventService
| }).compile(); | ||
| service = module.get<EventService>(EventService); | ||
| const testEvent: EventList = EventList.NewToken | ||
| expect(await mockedEventService.getEvents(testEvent)).toBeDefined(); |
There was a problem hiding this comment.
I think testing what should be returned is better
| constructor() {} | ||
| private eventIndex: number = 0; | ||
|
|
||
| constructor(@Inject('CONTRACT') private contract) { |
There was a problem hiding this comment.
Write type of contract.
And i think naming contractFactory would be better
| }).compile(); | ||
| abi = module.get<AbiConfig>(AbiConfig); | ||
| }); | ||
| it('#getGhostAbi()', () => { |
There was a problem hiding this comment.
Doesnt need to test other get~abi?
|
|
||
| describe('AbiProvider', () => { | ||
| let abi: AbiConfig; | ||
| const pth = '/Users/Kyudong/Desktop/hatchout/hatchout/server/src/port/adapter/service/blockchain/ethereum/web3'; |
There was a problem hiding this comment.
I think it can be only tested on your local pc because there is “Kyodong”
| it('should return specific Contract', async () => { | ||
| const event = EventList.AuctionCreated; | ||
| const fac = contractFactory.getInstance(event); | ||
| expect(fac).toBeDefined(); |
There was a problem hiding this comment.
Is enough to test that fac is defined?
| getInstance(eventType: EventList) { | ||
| switch (EventType[eventType]) { | ||
| case 'Ghost': | ||
| return new this.web3.eth.Contract(this.abi.getGhostAbi()); |
There was a problem hiding this comment.
getGhostAbi return just empty array. Is it ok?
hihiboss
force-pushed
the
develop
branch
3 times, most recently
from
94e7c5d to
f12cf75
Compare
Related Issue
resolve: #7
Description
add eventService
Checklist
Thank you for your contribution.
Before submitting this PR, please make sure: