forked from DCP-CloudMesh/PeerToPeer
-
Notifications
You must be signed in to change notification settings - Fork 1
Seperate source (requestor) and target (provider) data or index file locations #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TonyxSun
wants to merge
25
commits into
integration
Choose a base branch
from
ftp_io_directories
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a88d454 to
b8642a7
Compare
Member
|
I think we should add |
a61629b to
ed3eb3a
Compare
[ML Integration] Integration Branch Combining C++ and Python Work
Modifications to allow P2P over Tailscale
* temp changes * changes made Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> * fix build errors * completed multiple iterations code Co-authored-by: Jordan Mao <[email protected]> Co-authored-by: Joon Kang <[email protected]> Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> * small bug fixes --------- Co-authored-by: jordanmao <[email protected]> Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> Co-authored-by: Joon Kang <[email protected]>
Implement better command line argument parsing for main.cpp using Boost
ed3eb3a to
3c82e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve the problem of 'frogomobile' by preventing simultaneous R/W into the same file (in the same directory, as was happening with the index files).
We can also actually send files now (before, we either rely on the optimization that the files already exist, so we don't need to initiate fetching, or have FTP commented out for actual training files. The only files we have sent before where the index files). This is pretty important if we are going to test multiple machines.
Fixed some misc. issues that were needed to get 10,000 + file transfers to happen, like dangling file pointers/sockets, excessive creation of new sockets, and added socket timeout.
So I defined the following macros:
The data should be in
SOURCE_DATA_DIRfor the requester. The training files will be downloaded toTARGET_DATA_DIRon the provider machines.Demo
https://www.youtube.com/watch?v=gSePWZN4YAs
TODO in a meeting: I arbitrarily set the names of the folders. We can confirm whether they make sense and also the training scripts might need to changed to read from new folders. One problem with this is that we can't send the test files for now. We need a way to specify the set of files we want and where to download them.