Skip to content

2504 fix CI failures #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifflander merged 3 commits into from
Feb 17, 2026
Merged

2504 fix CI failures #2505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7bd175
#2504: zoltanlb: fix format specifier
lifflander Feb 16, 2026
60e4242
#2504: zoltanlb: another fix for format specifier
lifflander Feb 17, 2026
1cc0618
#2504: location: Fix test failure and potential performance issue
lifflander Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/vt/topos/location/location.impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ void EntityLocationCoord<EntityID>::sendEagerUpdate(
if (ask_node != this_node) {
vtAssert(ask_node != uninitialized_destination, "Ask node must be valid");
proxy_[ask_node].template send<&ThisType::handleEagerUpdate>(
id, home_node, deliver_node
MsgProps().asLocationMsg(), id, home_node, deliver_node
);
}
}
Expand All @@ -574,15 +574,15 @@ void EntityLocationCoord<EntityID>::routeMsgNode(

if (to_node != this_node) {
// Get the current ask node, which is the from node for the first hop
auto ask_node = msg->getAskNode();
if (ask_node != uninitialized_destination) {
// Insert into the ask list for a later update when information is known
loc_asks_[id].insert(ask_node);
auto prev_ask = msg->getAskNode();
if (prev_ask != uninitialized_destination) {
// Record previous asker for cascaded updates
loc_asks_[id].insert(prev_ask);
} else {
// Set initial ask node to the sender for direct eager update later
msg->setAskNode(this_node);
}

// Update the new asking node, as this node is will be the next to ask
msg->setAskNode(this_node);

auto m = msg; //copy for msg thief
// send to the node discovered by the location manager
proxy_[to_node].template sendMsg<&ThisType::routedHandler<MessageT>>(m);
Expand Down Expand Up @@ -630,7 +630,11 @@ void EntityLocationCoord<EntityID>::routeMsgNode(

if (ask_node != uninitialized_destination) {
auto delivered_node = theContext()->getNode();
// Tie the eager update to the same epoch as the routed message
auto epoch_local = theMsg()->getEpochContextMsg(msg);
theMsg()->pushEpoch(epoch_local);
sendEagerUpdate(hid, ask_node, home_node, delivered_node);
theMsg()->popEpoch(epoch_local);
}
};

Expand Down
6 changes: 3 additions & 3 deletions src/vt/vrt/collection/balance/zoltanlb/zoltanlb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ void ZoltanLB::allocateShareEdgeGIDs() {

vt_debug_print(
verbose, lb,
"allocate: local edge_id={:x}, from={:x}, to={:x}\n",
"allocate: local edge_id={:x}, from={}, to={}\n",
key.edge_id_.id,
key.fromObj(),
key.toObj()
Expand All @@ -386,7 +386,7 @@ void ZoltanLB::allocateShareEdgeGIDs() {

vt_debug_print(
verbose, lb,
"allocate: remote edge_id={:x}, from={:x}, to={:x}\n",
"allocate: remote edge_id={:x}, from={}, to={}\n",
key.edge_id_.id,
key.fromObj(),
key.toObj()
Expand Down Expand Up @@ -563,7 +563,7 @@ std::unique_ptr<ZoltanLB::Graph> ZoltanLB::makeGraph() {

vt_debug_print(
verbose, lb,
"edge_id={:x} from={:x}, to={:x}\n",
"edge_id={} from={}, to={}\n",
iter->first.edge_id_,
iter->first.fromObj(), iter->first.toObj()
);
Expand Down
Loading