Merged
Conversation
Closed
cwschilly
commented
Mar 10, 2025
lifflander
reviewed
Mar 10, 2025
Contributor
|
Overall, this looks good. I think we need to get the tests in here before merging. If you can prioritize that we can get this merged. |
lifflander
requested changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
This PR adds:
Sensors output:
slow_node.ccrunssensorson all cores, reduces them per node to save only the max temp recorded on each core, and then gathers everything onto one rank to write the output tosensors.logTemperature analysis: Over-heated nodes are shown in the output of the
detect()function. Use-s /path/to/sensors.logto point to the sensors output from the slow_node executableOption to specify number of nodes: Use
-N <num-nodes>on the command line to specify the target number of nodes required for an application. The SlowNodeDetector will include at most that many nodes in the finalhostfile.Basic unit testing for the Python analysis code (this should be revisited in a subsequent issue/PR)