Add Config to have budget bar hard pledges use appointment date instead of pledge sent at#3348
Open
colinxfleming wants to merge 7 commits intomainfrom
Open
Add Config to have budget bar hard pledges use appointment date instead of pledge sent at#3348colinxfleming wants to merge 7 commits intomainfrom
colinxfleming wants to merge 7 commits intomainfrom
Conversation
…nt into colin/appt-date
lomky
reviewed
Mar 12, 2025
| else | ||
| patients = base.where(pledge_sent_at: start_of_period..) | ||
| end | ||
| patients = patients.or(base.where(fund_pledged_at: start_of_period..)) |
Member
There was a problem hiding this comment.
I think this line will catch patients who are pledged this period with an appointment in later periods, so we need to add change the budget bar helper to mark them as soft pledged.
Actually as i'm thinking it over, how should we handle the soft pledges here? should soft pledges appear in the current period (when the pledge is created) or the one tied to the appointment date?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rule and have completed some work on Case Manager that's ready for review!
Per request of fund, make it so that hard pledges (green in the pledge bar) get tied to appointment date rather than pledge sent at.
This pull request makes the following changes:
Patient.pledged_status_summaryto utilizeno view changes
It relates to the following issue #s:
For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.