Homescreen UI revamp#114
Draft
chaitika wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the wallet list/home UI styling and theming, adds new iconography and custom fonts, and aligns several loading indicators/buttons with the active theme (including dark mode support).
Changes:
- Reworks
WalletsListheader/actions/empty state UI (new toast, icons, balance formatting, and styling). - Adds Clash Grotesk font integration (RN assets config + iOS/Android manifests/plists) and introduces
ClashFontconstants. - Improves theme usage across the app (dark theme export/use, themed activity indicators, themed settings button, color-scheme switching).
Reviewed changes
Copilot reviewed 20 out of 30 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| screen/wallets/WalletsList.tsx | New wallet header/actions/empty state UI, toast behavior, and theme-driven styles/icons |
| screen/UnlockWith.tsx | Theme-colored ActivityIndicator |
| react-native.config.js | Registers font assets for React Native linking |
| navigation/LazyLoadingIndicator.tsx | Theme-colored ActivityIndicator |
| navigation/DetailViewScreensStack.tsx | Passes theme colors into SettingsButton |
| loc/en.json | Adds new strings for empty state, toast, and button labels |
| ios/link-assets-manifest.json | Adds generated font linking manifest for iOS |
| ios/Widgets/Info.plist | Registers Clash fonts for the Widgets target |
| ios/Shroud/Info.plist | Registers Clash fonts for the app target |
| ios/Shroud.xcodeproj/project.pbxproj | Adds font files to Xcode project resources |
| constants/fonts.ts | Adds ClashFont family constants and documentation |
| components/themes.ts | Adds new theme color tokens; exports BlueDarkTheme and updates dark palette |
| components/icons/ShieldReceiveIcon.tsx | New SVG icon component for empty state |
| components/icons/SettingsButton.tsx | Replaces RNE icon with themed SVG button |
| components/icons/SearchIcon.tsx | New SVG icon component |
| components/icons/ReceiveArrowIcon.tsx | New SVG icon component |
| components/icons/QRScanIcon.tsx | New SVG icon component |
| components/icons/PayArrowIcon.tsx | New SVG icon component |
| android/link-assets-manifest.json | Adds generated font linking manifest for Android |
| App.tsx | Adds color-scheme based theming and moves indexer/bridge init into effects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+291
to
+293
| <View style={styles.trackPaymentIconCircle}> | ||
| <SearchIcon size={38} background={colors.searchIconBackground} stroke={colors.searchIconStroke} /> | ||
| </View> |
Comment on lines
+304
to
+312
| }, [ | ||
| stylesHook.listHeaderBack, | ||
| stylesHook.trackPaymentBg, | ||
| stylesHook.foregroundText, | ||
| stylesHook.alternativeText, | ||
| navigation, | ||
| wallets, | ||
| dataSource.length, | ||
| ]); |
Comment on lines
+428
to
+433
| <View style={[styles.emptyCard, stylesHook.cardStyle]} testID="NoTransactionsMessage"> | ||
| <View style={styles.emptyIconOuter}> | ||
| <ShieldReceiveIcon size={94} background={colors.shieldIconBackground} borderColor={colors.shieldIconBorder} accent={colors.shieldIconAccent} /> | ||
| </View> | ||
| <Text style={[styles.emptyTitle, stylesHook.foregroundText]}>{loc.wallets.no_transactions_title}</Text> | ||
| <Text style={[styles.emptySubtitle, stylesHook.alternativeText]}>{loc.wallets.no_transactions_subtitle}</Text> |
Comment on lines
+445
to
+455
| }, [ | ||
| dataSource.length, | ||
| isLoading, | ||
| wallets, | ||
| navigation, | ||
| stylesHook.cardStyle, | ||
| stylesHook.foregroundText, | ||
| stylesHook.alternativeText, | ||
| stylesHook.shareAddrStyle, | ||
| stylesHook.shareAddrText, | ||
| ]); |
Comment on lines
+361
to
+392
| <View style={styles.actionRow}> | ||
| <TouchableOpacity | ||
| style={[styles.actionBtnWide, stylesHook.receiveBtnStyle]} | ||
| onPress={onReceiveButtonPressed} | ||
| testID="HomeScreenReceiveButton" | ||
| > | ||
| <ReceiveArrowIcon color={colors.requestBtnTextColor} size={28} /> | ||
| <Text style={[styles.actionBtnLabel, stylesHook.requestBtnLabel]}>{loc.wallets.request_button}</Text> | ||
| </TouchableOpacity> | ||
|
|
||
| <TouchableOpacity | ||
| style={[styles.actionBtnSquare, stylesHook.scanBtnStyle]} | ||
| onPress={onScanButtonPressed} | ||
| testID="HomeScreenScanButton" | ||
| > | ||
| <QRScanIcon color={colors.buttonBackgroundColor} size={22} /> | ||
| </TouchableOpacity> | ||
|
|
||
| <TouchableOpacity | ||
| style={[styles.actionBtnWide, styles.actionBtnNoBorder, hasBalance ? stylesHook.payBtnActive : stylesHook.payBtnDisabled]} | ||
| onPress={hasBalance ? onSendButtonPressed : triggerZeroBalanceToast} | ||
| onLongPress={hasBalance ? sendButtonLongPress : undefined} | ||
| testID="HomeScreenSendButton" | ||
| > | ||
| <PayArrowIcon color={colors.payBtnTextColor} size={28} /> | ||
| <Text style={[styles.actionBtnLabel, stylesHook.payBtnLabel]}>{loc.wallets.pay_button}</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
| </View> | ||
| ); | ||
| }, [wallets, stylesHook, changeWalletBalanceUnit]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [wallets, stylesHook, colors, changeWalletBalanceUnit]); |
Comment on lines
+354
to
+357
| <View style={styles.balanceRow}> | ||
| <Text style={[styles.balanceNumber, stylesHook.foregroundText]}>{displayNum}</Text> | ||
| <Text style={[styles.balanceUnit, stylesHook.alternativeText]}>{preferredUnit}</Text> | ||
| </View> |
Comment on lines
+14
to
+16
| import { useColorScheme } from 'react-native'; | ||
|
|
||
| if (!INDEXER_BASE_URL) throw new Error('INDEXER_BASE_URL is not set'); |
Comment on lines
+21
to
+27
| useEffect(() => { | ||
| initializeRustJsiBridge(); | ||
| initializeIndexer({ | ||
| baseUrl: INDEXER_BASE_URL, | ||
| timeout: 100000, | ||
| }); | ||
| }, []); |
Comment on lines
+2
to
+5
| * Clash Grotesk font family names, as registered by the native font assets | ||
| * (see assets/fonts and react-native.config.js). On both iOS and Android the | ||
| * family name resolves to the font's PostScript name, so reference a specific | ||
| * weight via `fontFamily` and avoid relying on `fontWeight`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign the Home Screen as per design document for both light and dark themes