perf: batch POM resolution and cache parent POM lookups#802
Open
MalickBurger wants to merge 1 commit intomasterfrom
Open
perf: batch POM resolution and cache parent POM lookups#802MalickBurger wants to merge 1 commit intomasterfrom
MalickBurger wants to merge 1 commit intomasterfrom
Conversation
Resolve all component POM files in a single Gradle artifact resolution query instead of N individual calls. Share a single ModelResolver instance per project so parent POM resolutions are cached across components. Signed-off-by: MalickBurger <malickjackburger@gmail.com>
skhokhlov
requested changes
Mar 13, 2026
Member
skhokhlov
left a comment
skhokhlov
left a comment
There was a problem hiding this comment.
It would be nice if you attach benchmark results before and after the change. https://github.com/gradle/gradle-profiler?tab=readme-ov-file#benchmarking-a-build
| return; | ||
| } | ||
|
|
||
| LOGGER.info("CycloneDX: Batch resolving {} POM files", componentIds.size()); |
Member
There was a problem hiding this comment.
All log messages in this project follow pattern LOGGER.log("{} Message", LOG_PREFIX). It helps to identify plugin logs in Gradle build. Please use it in this PR too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all component POM files in a single Gradle artifact resolution query instead of N individual calls. Share a single ModelResolver instance per project so parent POM resolutions are cached across components.