Skip to content

rpc: implement set_log_level and set_log_categories handlers #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielBoye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rpc: implement set_log_level and set_log_categories handlers #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 66 additions & 6 deletions binaries/cuprated/src/rpc/handlers/other_json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ use cuprate_types::{
};

use crate::{
logging,
rpc::{
constants::UNSUPPORTED_RPC_CALL,
handlers::{
Expand Down Expand Up @@ -81,8 +82,8 @@ pub async fn map_request(
}
Req::SaveBc(r) => Resp::SaveBc(not_available()?),
Req::GetPeerList(r) => Resp::GetPeerList(not_available()?),
Req::SetLogLevel(r) => Resp::SetLogLevel(not_available()?),
Req::SetLogCategories(r) => Resp::SetLogCategories(not_available()?),
Req::SetLogLevel(r) => Resp::SetLogLevel(set_log_level(state, r).await?),
Req::SetLogCategories(r) => Resp::SetLogCategories(set_log_categories(state, r).await?),
Req::GetTransactionPool(r) => Resp::GetTransactionPool(not_available()?),
Req::GetTransactionPoolStats(r) => Resp::GetTransactionPoolStats(not_available()?),
Req::StopDaemon(r) => Resp::StopDaemon(not_available()?),
Expand Down Expand Up @@ -757,18 +758,77 @@ async fn update(

/// <https://github.com/monero-project/monero/blob/cc73fe71162d564ffda8e549b79a350bca53c454/src/rpc/core_rpc_server.cpp#L1641-L1652>
async fn set_log_level(
state: CupratedRpcHandler,
_state: CupratedRpcHandler,
request: SetLogLevelRequest,
) -> Result<SetLogLevelResponse, Error> {
todo!()
use tracing::level_filters::LevelFilter;

let level = match request.level {
0 => LevelFilter::ERROR,
1 => LevelFilter::WARN,
2 => LevelFilter::INFO,
3 => LevelFilter::DEBUG,
4 => LevelFilter::TRACE,
_ => {
return Err(anyhow!(
"Invalid log level: {}. Valid range is 0-4",
request.level
))
}
};

logging::modify_stdout_output(|filter| {
filter.level = level;
});
logging::modify_file_output(|filter| {
filter.level = level;
});

Ok(SetLogLevelResponse {
base: helper::response_base(false),
})
}

/// <https://github.com/monero-project/monero/blob/cc73fe71162d564ffda8e549b79a350bca53c454/src/rpc/core_rpc_server.cpp#L1654-L1661>
async fn set_log_categories(
state: CupratedRpcHandler,
_state: CupratedRpcHandler,
request: SetLogCategoriesRequest,
) -> Result<SetLogCategoriesResponse, Error> {
todo!()
use tracing::level_filters::LevelFilter;
use tracing_subscriber::filter::EnvFilter;

let categories = if request.categories.is_empty() {
"*:INFO".to_string()
} else {
request.categories.clone()
};

let level_filter = if let Ok(_env_filter) = EnvFilter::try_new(&categories) {
if categories.starts_with("*:") {
let level_str = categories.strip_prefix("*:").unwrap_or("INFO");
level_str
.parse::<LevelFilter>()
.unwrap_or(LevelFilter::INFO)
} else {
LevelFilter::INFO
}
} else {
categories
.parse::<LevelFilter>()
.unwrap_or(LevelFilter::INFO)
};

logging::modify_stdout_output(|filter| {
filter.level = level_filter;
});
logging::modify_file_output(|filter| {
filter.level = level_filter;
});

Ok(SetLogCategoriesResponse {
base: helper::response_base(false),
categories,
})
}

//---------------------------------------------------------------------------------------------------- Unsupported RPC calls (forever)
Expand Down
Loading