-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring, bug fixes #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update imports
CuddlyBunion341
commented
Jan 28, 2025
CuddlyBunion341
commented
Jan 28, 2025
Vec3 { | ||
x: 0.0, | ||
y: 0.0, | ||
z: 0.0, | ||
}, | ||
1, | ||
Vec3::new(1.0, 1.0, 1.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I like the method "overload" with the integer param for the render distance more than this vector definition..
CuddlyBunion341
commented
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of Terrain related Code (and some other stuff)
Implementing the improved terrain showed some serious flaws with the organization of code shared between the client and server binaries and also revealed some serious bugs.
Started off from #33
Note
I know this is not a clean refactoring as there are some functionality changes made. I don't care this is my project, I will do whatever I want. Especially if it enables me to go faster.
Problem assessment
lib.rs
was unmaintainable as it exploded in size with all sorts of code ranging from Networking Message declarations to serialization and Resource definitions.Key Changes
ChunkManager
,Chunk
,BlockId
and such have been moved to this new namespace (shared
).shared
module has been created which is imported aslib
viarsmc
.lib::
prefix has been dropped as it is unnecessary.i32
parameterized chunk initialization method. (Maybe this should be reverted?) 6e64d22Notes
...