fix: improve pg_stat_statements individual metric panels#454
Merged
keithf4 merged 3 commits intoCrunchyData:developmentfrom Mar 3, 2025
Merged
fix: improve pg_stat_statements individual metric panels#454keithf4 merged 3 commits intoCrunchyData:developmentfrom
keithf4 merged 3 commits intoCrunchyData:developmentfrom
Conversation
YorviArias
approved these changes
Mar 1, 2025
hunleyd
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lifetime stats should be using the
instantmaxvalue. Mean causes Grafana to average out all values which makes no sense, even if you do ask for a time rangeMade new time range panels for the same value panels to reflect the requested time range values. It takes the difference between the min and max values for that range. Since these are always incrementing values, the low time range should always be the min and high time range the max. Grafana still does weird "smoothing" on these values, even if you chose the max possible time range, so they never match the lifetime values. Hence marking them
Est.Doing a time range value for the mean doesn't make sense with the way the metric is gathered right now, so left that one out.
Please indicate what kind of change your PR includes (multiple selections are acceptable):
PRs should be against existing issues, so please list each issue using a separate 'closes' line:
closes #449
If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.
depends on #
If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.
Testing
None of the testing listed below is optional.
Code testing
Have you tested your changes against:
If your code touches sql_exporter, have you:
If your code touches node_exporter, have you:
If your code touches Prometheus, have you:
promtool check configpromtool check rulesIf your code touches Grafana, have you:
Checklist: