Add Phone Number Linking #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this on iOS but not on Android. I have no physical Android device to test this on. |
|
Sorry I haven't been able to address this sooner. Could you please add tests? It's unclear from the regex what type of phone numbers (they are multiple formats internationally) are support from this. Additionally, adding some docs in the README would be useful. I wouldn't activate this as a default linkifier as it may parse non-phone numbers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
PhoneNumberLinkifier(phone_number.dart) that parses phone numbers and allows opening of phone number URLs (tel:##########).