Add support for harvesting 'double-high' crops (Immersive Engineering Hemp)#9991
Open
TeamSpen210 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Open
Add support for harvesting 'double-high' crops (Immersive Engineering Hemp)#9991TeamSpen210 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
TeamSpen210 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE's hemp crop grows, but has a final stage which is double-high. Currently it does harvest, but the upper block is simply broken from lack of support, dropping items randomly. This adds special handling for the crop - if aimed at the upper block it's broken, while aiming at the lower block breaks and replants the whole crop. I guarded this behind a block tag for safety. This could alternatively just trigger when
BlockStateProperties.DOUBLE_BLOCK_HALFis present, but I could imagine other mods using that for some slightly different semantics. Happy to drop the tag if it's preferred.Not sure if the generated tags should be committed, looks like the dough tag changes weren't and so ended up here.
Fixes #8712.