Fix send only button in postboxes not working#9889
Open
JensenJ wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix send only button in postboxes not working#9889JensenJ wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
JensenJ wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Conversation
Fixed an oversight where the send only button inside the postbox UI wasn't actually implemented. Before delivering a package in pathfinding we also now check if the postbox is send only, and if it is we ignore it, this same logic applies during mail transfer. The navigation failure message for postbox address mismatch might want updating to reflect this new condition.
Fixed a bug in the fix for send only postboxes not saving state between world reloads.
Updated localisation for a train status message that could appear due to a postbox not being able to accept a package due to send only mode being enabled. Ran datagen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally part of #9826
Fixes #7939
Fixes a bug where the send only option in the postbox UI was not respected. Localization of the train status message has been updated to reflect this change and datagen has been ran for this.
Let me know if there's anything I need to change or if you have any ideas to how it could be improved.
Thanks,
Jensen