Skip to content

Fix placed shulkers always counting as empty #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VoidLeech wants to merge 1 commit into
base: mc1.21.1/dev
Choose a base branch
from
Open

Fix placed shulkers always counting as empty #10026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...imibubi/create/compat/computercraft/implementation/peripherals/DisplayLinkPeripheral.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public DisplayLinkPeripheral(DisplayLinkBlockEntity blockEntity) {
@LuaFunction
public final void setCursorPos(int x, int y) throws LuaException {
if (x < 1 || y < 1)
throw new LuaException("cursor position must be larger then 0");
throw new LuaException("cursor position must be larger than 0");

cursorX.set(x - 1);
cursorY.set(y - 1);
Expand Down
16 changes: 13 additions & 3 deletions ...ain/java/com/simibubi/create/content/redstone/smartObserver/SmartObserverBlockEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
import net.minecraft.world.Clearable;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.ShulkerBoxBlock;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.ShulkerBoxBlockEntity;
import net.minecraft.world.level.block.state.BlockState;

public class SmartObserverBlockEntity extends SmartBlockEntity implements Clearable {
Expand Down Expand Up @@ -81,9 +83,17 @@ public void tick() {
.getBlock();

if (!filtering.getFilter()
.isEmpty() && block.asItem() != null && filtering.test(new ItemStack(block))) {
activate(3);
return;
.isEmpty() && block.asItem() != null) {
ItemStack stack = new ItemStack(block);
if (block instanceof ShulkerBoxBlock
&& level.getBlockEntity(targetPos) instanceof ShulkerBoxBlockEntity shulkerBoxBlockEntity
&& !shulkerBoxBlockEntity.isEmpty()) {
stack.applyComponents(shulkerBoxBlockEntity.collectComponents());
Copy link
Member

@IThundxr IThundxr Mar 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it perhaps make sense to just collect and apply components for all block entities for all shulker box like cases?

Copy link
Collaborator Author

@VoidLeech VoidLeech Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting thought.

Even outside other mods adding new attributes types where it'd be useful to not have to mixin into Create to have their BE also pass the component map to the filtered stack, that opens up new interactions where ItemNameAttribute can compare with the name of placed BE's (even say, a cogwheel that only has that name due to getting placed by an item with that name), or the list filter with similar effect on the entire component map it had.

I don't hate it but to players that might feel very arbitrary to which blocks you can detect what stack it was placed with. (Admittedly, this PR does also just add have the behaviour I describe for shulkers specifically actually not quite it won't be able to detect the name of empty shulkers). lmk what you'd think is best

}
if (filtering.test(stack)) {
activate(3);
return;
}
}

// Detect items on belt
Expand Down