Skip to content

fix(GradesChart): update grade distribution ViolinChart to LineChart #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

fix(GradesChart): update grade distribution ViolinChart to LineChart #7952

merged 1 commit into from
May 29, 2025

Conversation

craigtonlian
Copy link
Contributor

@craigtonlian craigtonlian commented May 26, 2025 •
edited
Loading

  • Update statistics tab labels from "mark" to "grade"
  • Update ViolinChart to LineChart for grade distribution
    • Horizontal axis displays 0 to maximumGrade of the assessment
    • Vertical axis displays 0 to the highest number of submissions per grade + 1
      image

@craigtonlian craigtonlian force-pushed the craigtonlian/update-grade-graph branch 2 times, most recently from 891008c to 792251a Compare May 27, 2025 07:01
@craigtonlian craigtonlian marked this pull request as ready for review May 27, 2025 07:03
adi-herwana-nus
adi-herwana-nus requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@adi-herwana-nus adi-herwana-nus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. LineChart should be converted to TSX
  2. if ViolinChart isn't being referenced anymore, then it should be deleted

@craigtonlian craigtonlian force-pushed the craigtonlian/update-grade-graph branch 2 times, most recently from e1e9faf to 7e894a3 Compare May 28, 2025 08:41
@craigtonlian craigtonlian force-pushed the craigtonlian/update-grade-graph branch from 7e894a3 to 565ac66 Compare May 28, 2025 15:25
@adi-herwana-nus adi-herwana-nus merged commit 71b292c into master May 29, 2025
13 of 14 checks passed
@adi-herwana-nus adi-herwana-nus deleted the craigtonlian/update-grade-graph branch May 29, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adi-herwana-nus adi-herwana-nus adi-herwana-nus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigtonlian @adi-herwana-nus