Skip to content

feat(RubricBasedResponse): add RubricBasedResponse to submission CSV and statistics table #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(RubricBasedResponse): add RubricBasedResponse to submission CSV and statistics table #7951

wants to merge 2 commits into from

Conversation

craigtonlian
Copy link
Contributor

@craigtonlian craigtonlian commented May 26, 2025 •
edited
Loading

  • Add RubricPanel to Course > Assessment > Statistics > Grades Per Question > Rubric Based Response Question

    • Extracted all data fetching logic outside of RubricPanel
    • RubricPanel now receives all required data via props — making it more extensible and easier to reuse
    • Past answer now displays student answers for Rubric Based Response questions as well as Rubric Panel.
      image

  • Add CSV export for RubricBasedResponse answers in Assessment > Submissions > Download Answers (CSV)

    • In the exported CSV file, answers for Rubric Based Response questions will now appear similar to Text Response answers.
      image

@craigtonlian craigtonlian force-pushed the craigtonlian/fix-assignment-rubric-csv branch 5 times, most recently from cd221df to 8677827 Compare May 29, 2025 07:41
@craigtonlian craigtonlian marked this pull request as ready for review May 29, 2025 07:46
adi-herwana-nus
adi-herwana-nus requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@adi-herwana-nus adi-herwana-nus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSV download works as expected. Past answer display (on GradesPerQuestionTable) needs work:

  1. Why are we calling fetchSubmission and introducing extra logic there?
    LastAttemptIndex and related components already call fetchAnswer, it should return sufficient data for you to use.

  2. Displaying total grade / maximum grade per rubric category would be helpful, since instructor can't edit the past answer view there isn't a way to quickly reference the maximum grade.
    For example, this is what we display for text response questions:

Screenshot 2025-06-03 at 13 03 06

@craigtonlian craigtonlian force-pushed the craigtonlian/fix-assignment-rubric-csv branch from 8677827 to 6b3c11f Compare June 3, 2025 05:18
@craigtonlian craigtonlian force-pushed the craigtonlian/fix-assignment-rubric-csv branch 4 times, most recently from 33d83bd to 27cc8ee Compare June 3, 2025 12:50
@craigtonlian craigtonlian force-pushed the craigtonlian/fix-assignment-rubric-csv branch from 27cc8ee to 624d8e2 Compare June 3, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adi-herwana-nus adi-herwana-nus adi-herwana-nus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigtonlian @adi-herwana-nus