Find and build all packages individually #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
reviewed
Aug 19, 2020
| for contract_dir in "${contract_dirs[@]}"; do | ||
| echo "Building contract in $(realpath -m "$contract_dir")" | ||
| ( | ||
| cd "$contract_dir" |
There was a problem hiding this comment.
The issue of the . directory being called in any random order and overriding others can be fixed here if we just filter for actual crates (eg. if there is the members field in Cargo.toml skip it)
Otherwise, I like the find
|
Closing as this is a dead end as described in #21 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
So, the basic idea is: find all
Cargo.tomls and run an optimized build in their directories. An optional argument serves as a filtering path.The verification process for cosmwasm-plus is still not solved because:
. ./contracts/cw20-base ./contracts/cw20-escrow ./contracts/cw1-whitelist ./contracts/cw1-subkeys ./packages/cw1 ./packages/cw20 ./packages/cw2in no defined order, such that the build in.can override the individual contracrt builds. This can only be solved by providing a path argument for filtering.