Skip to content

Add pubkey recovery API #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 22, 2021
Merged

Add pubkey recovery API #790

merged 24 commits into from
Feb 22, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Feb 18, 2021

  • Implementation
  • Return uncompressed pubkey instead of compressed
  • Use Ethereum address to identify signer in example

Closes #765

@webmaster128 webmaster128 marked this pull request as ready for review February 18, 2021 23:14
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Main issues I have:

  • Passing of the recovery parameter in the recover pubkey API. Wouldn't be better to handle all that internally?
  • Error types proliferation (and associated boilerplate).
  • Asking for and validating the signer's address. Perhaps that could be another API / contract call?.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helpers.

@webmaster128 webmaster128 added the automerge See mergify.io label Feb 22, 2021
@mergify mergify bot merged commit c4a583c into main Feb 22, 2021
@mergify mergify bot deleted the recover_pubkey branch February 22, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge See mergify.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add secp256k1_recover_pubkey API
2 participants