Skip to content

Adds secp256k1_verify API #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 103 commits into from
Feb 17, 2021
Merged

Adds secp256k1_verify API #779

merged 103 commits into from
Feb 17, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Feb 9, 2021 •
edited
Loading

Continuation / refactoring of #770.

Closes #780.

Creates a cosmwasm-crypto package, that can be imported from both, cosmwasm-std (for MockApi impls / tests) and cosmwasm-vm (for native impl of verification fns).

Uses platform-specific-dependencies to avoid importing / compiling cosmwasm-crypto for wasm32 targets.

Still requires:

  • Extended low level tests (wrong hash, wrong signature, wrong pubkey values / lengths).
  • Native imports tests.
  • API tests (basic).
  • Contract tests. Done in Crypto api contract #783.
  • Improved docs.

@maurolacy maurolacy self-assigned this Feb 9, 2021
@maurolacy maurolacy mentioned this pull request Feb 9, 2021
Closed
webmaster128
webmaster128 reviewed Feb 9, 2021
View reviewed changes
webmaster128
webmaster128 reviewed Feb 10, 2021
View reviewed changes
@maurolacy maurolacy force-pushed the crypto-api-package branch 2 times, most recently from 10cb8b1 to d50d2f4 Compare February 10, 2021 09:51
@maurolacy
k256 signature verification tests
9e6fd41
@maurolacy
Add extra Cosmos signature verification tests
4bfe8a8 
Include non low-S signatures normalization
@maurolacy
Fix syntax
7bb74d9
@maurolacy
Use verify_digest along with manual/explicit hashing
c9e37b0
@maurolacy
Update lock files
605e818
@maurolacy
Add dummy Sha256 / Sha224 Digest impls
edb0452
@maurolacy
Add secp256k1_verify impl / tests
e50f7f5
@maurolacy
Adapt Cosmos tests
33489ff
@maurolacy
Adapt extra Cosmos tests
a0977eb 
Publish fn to avoid clippy warning
@maurolacy
Add secp256k1_verify to Api
fe82c3d 
Implement secp256k1_verify for MockApi
@maurolacy
Remove fn publication
f27fb37
@maurolacy
Add VmError::CryptoErr
40b0fa9
@maurolacy
Remove unneeded BlockInfo trait impl
3d63c8c
@maurolacy
Use super for tests
5e84d90
@maurolacy
Remove redundant imports
3c79ba0
@maurolacy
Optimize required features
8848ceb
@maurolacy
Fix Reset impl
d62c6d8
@maurolacy
Renamed dummy hashes for clarity
d1df2d5
@maurolacy
Remove unused dummy Sha224
07f72e1
@maurolacy
Revert "Add secp256k1_verify to Api"
bec7db3 
This reverts commit 756a809.
@maurolacy
Better rand_core use
278eb3f
@maurolacy
Use message instead of hash as input
0f68b73
@maurolacy
Update schema
c490d11
@maurolacy
Use Sha256::digest()
0d2002c
@maurolacy
Transform verification in query
2892417
@maurolacy
Update schemas
2a20fc7
@maurolacy
Add crypto package README.md, update CHANGELOG.md, README.md
f509257
@maurolacy
Add secp256k1_verify documentation
dfec768
@maurolacy
Add error_code to crypto errors
693ddaa
@maurolacy
Add error mapping to VM crypto API
d31a55c
@maurolacy
Return errors from Mock and External crypto Api
92e0269
@maurolacy
Adapt crypto-verify contract to returning errors
4604523
@maurolacy
Add specific CryptoErr
81fcb6c
@maurolacy
Update README.md
8e3aba0
@maurolacy
Remove non_exhaustive, add "internal" comments / hidden directive
b14dcbe
@maurolacy
Add VerificationError enum / helpers
3fba059
@maurolacy
Implement From VerificationError for StdError
552b979
@maurolacy
Adapt crypto-verify contract to VerificationError
2d7cbf6
@maurolacy
Fix clippy warnings
685a293
@maurolacy
Remove internal TODO file
4f628bc
@maurolacy
Update crypto-verify README.md
9596060
webmaster128
webmaster128 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 🎉. Let's update this PR's title to make it specific to #780 and then merge.

@maurolacy maurolacy changed the title Crypto api package Adds secp256k1_verify API Feb 17, 2021
@webmaster128 webmaster128 added the automerge See mergify.io label Feb 17, 2021
@webmaster128 webmaster128 merged commit fda87cf into main Feb 17, 2021
@webmaster128 webmaster128 deleted the crypto-api-package branch February 17, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees

@maurolacy maurolacy

Labels
automerge See mergify.io Crypto APIs (AssemblyScript Reallocation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add secp256k1_verify API
2 participants
@maurolacy @webmaster128