Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EurekaMsg #2340

Merged
merged 4 commits into from
Jan 20, 2025
Merged

feat: Add EurekaMsg #2340

merged 4 commits into from
Jan 20, 2025

Conversation

jawoznia
Copy link
Contributor

close #2339

@jawoznia jawoznia requested a review from aumetra January 14, 2025 16:28
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Seems reasonable. Changelog worthy maybe?

@chipshort
Copy link
Collaborator

The types look good.
Do we add this to CosmosMsg in a follow-up PR? Because otherwise that step is missing. After that the next step would be to adjust the wasmvm types.

@jawoznia jawoznia force-pushed the add-eureka-send-packet branch from c4bfea2 to 3946f2b Compare January 20, 2025 13:16
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
autofix-ci bot and others added 2 commits January 20, 2025 13:24
@jawoznia jawoznia requested a review from aumetra January 20, 2025 14:12
@jawoznia jawoznia merged commit 4c4af13 into main Jan 20, 2025
39 checks passed
@jawoznia jawoznia deleted the add-eureka-send-packet branch January 20, 2025 15:38
@@ -84,6 +85,7 @@ pub enum CosmosMsg<T = Empty> {
Wasm(WasmMsg),
#[cfg(feature = "stargate")]
Gov(GovMsg),
Eureka(EurekaMsg),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a capability for this and feature-gate this line, since Eureka will probably not be available yet on all chains when we release the implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EurekaMsg
3 participants