-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add EurekaMsg #2340
feat: Add EurekaMsg #2340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay. Seems reasonable. Changelog worthy maybe?
The types look good. |
c4bfea2
to
3946f2b
Compare
Add missing link Co-authored-by: Aumetra Weisman <[email protected]>
@@ -84,6 +85,7 @@ pub enum CosmosMsg<T = Empty> { | |||
Wasm(WasmMsg), | |||
#[cfg(feature = "stargate")] | |||
Gov(GovMsg), | |||
Eureka(EurekaMsg), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a capability for this and feature-gate this line, since Eureka will probably not be available yet on all chains when we release the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
close #2339