BackendApi improvements #1985
Merged
BackendApi improvements #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
chipshort
reviewed
Jan 9, 2024
packages/vm/src/backend.rs
Outdated
Comment on lines
171
to
168
| pub trait BackendApi: Copy + Clone + Send { | ||
| fn canonical_address(&self, human: &str) -> BackendResult<Vec<u8>>; | ||
| fn human_address(&self, canonical: &[u8]) -> BackendResult<String>; | ||
| pub trait BackendApi: Clone { |
There was a problem hiding this comment.
Shouldn't this continue to require Send?
Or maybe it would be better to add the bound to the Send impl of Environment?
Very good point. This is probably all a leftover from trying to get everything to compile during the Wasmer 3 upgrade. Will revert the Send change in here and only drop the Copy requirement, which is overly strict IMO. Could you have a look into those Send and Sync implementations of Environment and how to make this code more solid? |
webmaster128
force-pushed
the
BackendApi-improvements
branch
from
ba31f2c to
df69d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addr_validate can be implemented in Go directly such that we do not need to get the canonical address through cgo into Rust and send it back to get the humanized address again.