Skip to content

Conversation

@ali-toghiani
Copy link

fixes #279

ngOnchanges checks input changes and only regenerates the qr if inputs that effect QR generation has changed.

@Cordobo Cordobo requested a review from Copilot August 20, 2025 18:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the QR code regeneration process by implementing selective change detection in the ngOnChanges lifecycle hook. Instead of regenerating the QR code on every input change, it now only regenerates when inputs that actually affect the visual appearance change.

  • Introduces selective change detection to prevent unnecessary QR code regeneration
  • Separates visual changes from accessibility attribute updates for better performance
  • Refactors accessibility attribute setting into a reusable method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ali-toghiani
Copy link
Author

Hi @Cordobo, I’ve addressed the feedback from Copilot in the recent commits. Please let me know if there’s anything else needed to move this PR forward or if you’re waiting on additional reviews. Happy to assist with any further changes! Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When changing language it results in re-rednering the component

1 participant