🐛 [VersionName] Probably handle error when trying to parse version part

CoolLibs · Feb 5, 2025 · 545f56d · 545f56d
1 parent 34a18ff
commit 545f56d
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/Version/VersionName.cpp b/src/Version/VersionName.cpp
@@ -18,7 +18,7 @@ auto VersionName::from(std::string name) -> std::optional<VersionName>
 
     auto       acc                           = std::string{};
     auto       nb_dots                       = 0;
-    auto const register_current_version_part = [&]() {
+    auto const register_current_version_part = [&]() -> bool { // Returns true iff it was successful
         try
         {
             int const nb = std::stoi(acc);
@@ -32,18 +32,20 @@ auto VersionName::from(std::string name) -> std::optional<VersionName>
                 assert(nb_dots == 2);
                 ver._patch = nb;
             }
+            return true;
         }
         catch (...)
         {
-            return std::nullopt;
+            return false;
         }
     };
 
     for (size_t i = 0; i <= ver._name.size(); ++i)
     {
         if (i == ver._name.size())
         {
-            register_current_version_part();
+            if (!register_current_version_part())
+                return std::nullopt;
             break;
         }
 
@@ -53,14 +55,16 @@ auto VersionName::from(std::string name) -> std::optional<VersionName>
         }
         else if (ver._name[i] == '.')
         {
-            register_current_version_part();
+            if (!register_current_version_part())
+                return std::nullopt;
             nb_dots++;
             if (nb_dots > 2)
                 break;
         }
         else if (ver._name[i] == ' ')
         {
-            register_current_version_part();
+            if (!register_current_version_part())
+                return std::nullopt;
             break;
         }
         else