extra VLC encoding tests

Convex-Dev · Sep 21, 2024 · d7f82d3 · d7f82d3
1 parent 8e37166
commit d7f82d3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/convex-core/src/test/java/convex/core/data/FormatTest.java b/convex-core/src/test/java/convex/core/data/FormatTest.java
@@ -22,16 +22,19 @@ public class FormatTest {
 		assertBadVLCEncoding("80ffffffffffffffffff7f"); // too long
 		assertBadVLCEncoding("ff80808080808080808000"); // long negative
 
-		// TODO: fix this
-		// assertBadVLCEncoding("8000"); // excess leading bytes
+		assertBadVLCEncoding("8000"); // excess leading bytes
+		assertBadVLCEncoding("8080"); // no termination
 
 		assertEquals(Format.MAX_VLC_LONG_LENGTH,Format.getVLCLength(Long.MAX_VALUE));
 		assertEquals(Format.MAX_VLC_LONG_LENGTH,Format.getVLCLength(Long.MIN_VALUE));
 	}
 
 	private void assertBadVLCEncoding(String hex) {
 		Blob b=Blob.fromHex(hex);
-		assertThrows(BadFormatException.class,()->Format.readVLCLong(b.getInternalArray(), b.getInternalOffset()));
+		assertThrows(BadFormatException.class,()->{
+			long val=Format.readVLCLong(b.getInternalArray(), b.getInternalOffset());
+			if (Format.getVLCLength(val)!=b.count()) throw new BadFormatException("Wrong length");
+		});
 	}
 
 	private void checkVLCEncoding(String hex, long a) {