Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "fix" for #18. I suspect it's wrong.
I couldn't get Chrome to accept my extension. I noticed that the CRXs that Chrome generates have 296-byte keys, but crxmake generates 316-byte keys because it tacks 22 bytes to the front of the key I provided. I removed the code that does that and now my extension works.
I suspect what's happening is that my key is coming with the right ceremonial prefix in it, but that crxmake isn't recognizing it as "correct" and thus tacking on its own, thereby breaking things. Perhaps my fix breaks other things, such as keys generated by crxmake itself (I didn't try it). I don't really know how this stuff works, what the prefix really does, or why it would be constant (seems a bit odd).