Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solution generation via default .bat #580

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Dec 5, 2024

This PR fixes solution generation issues when end users open the default GenerateAllSolution.bat by only enabling the default minimum MultiTargets (uwp, wasdk, wasm).

The underlying issue affects solution generation when android, ios or macos MultiTargets are requested or enabled. These targets don't have corresponding gallery or test heads that can be built, so they're unnecessary and have been disabled. This does not affect our ability to build these targets in CI.

Issue also reported in the Windows App Community Discord.

@Arlodotexe Arlodotexe self-assigned this Dec 5, 2024
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, want to open the tracking issue for resolving this long-term and link to from here?

@Arlodotexe Arlodotexe merged commit 5180e74 into main Dec 9, 2024
24 checks passed
@Arlodotexe Arlodotexe deleted the fix/solution-generation branch December 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants