Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the Ollama docs links #360

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fixing the Ollama docs links #360

merged 1 commit into from
Jan 3, 2025

Conversation

aaronpowell
Copy link
Member

@aaronpowell aaronpowell commented Dec 30, 2024 •
edited
Loading

Fixing the links to the Ollama docs

Closes #359

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@aaronpowell aaronpowell requested a review from Copilot December 30, 2024 23:27
Copilot
Copilot AI reviewed Dec 30, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.EventStore 100% 100% 46 ✔
CommunityToolkit.Aspire.Hosting.ActiveMQ 60% 24% 104 ❌
CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit 1% 0% 14 ❌
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 22 ✔
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 100% 100% 28 ✔
CommunityToolkit.Aspire.Hosting.Bun 81% 71% 54 ✔
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72 ✔
CommunityToolkit.Aspire.Hosting.EventStore 90% 71% 62 ✔
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16 ✔
CommunityToolkit.Aspire.Hosting.Java 98% 71% 58 ✔
CommunityToolkit.Aspire.Hosting.Meilisearch 61% 27% 94 ➖
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 68% 92 ✔
CommunityToolkit.Aspire.Hosting.Ollama 65% 64% 198 ➖
CommunityToolkit.Aspire.Hosting.Python.Extensions 67% 46% 56 ➖
CommunityToolkit.Aspire.Hosting.Rust 94% 83% 16 ✔
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 75% 61% 96 ➖
CommunityToolkit.Aspire.MassTransit.RabbitMQ 100% 100% 30 ✔
CommunityToolkit.Aspire.Meilisearch 97% 92% 68 ✔
CommunityToolkit.Aspire.OllamaSharp 87% 82% 68 ✔
Summary 76% (2371 / 3108) 63% (588 / 932) 1194 ➖

Minimum allowed line rate is 60%

@aaronpowell aaronpowell merged commit 3332a14 into main Jan 3, 2025
10 checks passed
@aaronpowell aaronpowell deleted the ollama-docs-links branch January 3, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ollama docs links are wrong
1 participant
@aaronpowell