refactor(signer): Use config-based header to extract IP from #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclapis
requested changes
Oct 13, 2025
| .get(header) | ||
| .ok_or(eyre::eyre!("{header} header not found"))? | ||
| .to_str()? | ||
| .parse() |
There was a problem hiding this comment.
I think this is going to run into 2 problems:
- When the header is set multiple times in the request, but the HTTP spec mandates that it should only be set once; this should be handled like a malformed input.
client-ipknows when to look for it:
X-Real-Ip(Nginx)True-Client-IP(Akamai, Cloudflare)Fly-Client-IP(Fly.io)CF-Connecting-IP(Cloudflare)
- In other cases, the header can be set multiple times or can have multiple values; for example,
X-Forwarded-Foris actually a comma-separated string with multiple IPs, and we have to use the rightmost one.
Perhaps there should be a more elaborate config for proxy stuff like this so the user can customize the behavior they'll actually encounter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config param to set the trusted HTTP header to get the user's IP from