-
Notifications
You must be signed in to change notification settings - Fork 55
CBST2-12: Improve External HTTP Requests #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jclapis
wants to merge
64
commits into
main
Choose a base branch
from
improve-http-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+455
−34
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
c68125d
bump version
ltitanb d9979a2
Successful cross-compilation, but runtime has memory allocation issues
jclapis 97ef653
Working with OpenSSL static-linked
jclapis 91eefe2
Got dynamic linking working, added a feature flag to toggle dynamic v…
jclapis de09415
Fixed the vendored build arg
jclapis 3aee63d
Reintroduced the cargo chef setup
jclapis c07c717
Ported the cross-compilation stuff into PBS
jclapis 699b7ec
Split the dockerfiles into separate builder / image definitions
jclapis 7165f12
Added a build guide
jclapis 9438dae
Refactored the Github release action to use the Docker builder
jclapis 12c020a
Fixed the Docker image binary filenames
jclapis 53cafc0
Cleaned up the Darwin artifact step
jclapis 58c6117
Made the CI workflow and justfile use the same toolchain as the source
jclapis 45e581b
Revert "Made the CI workflow and justfile use the same toolchain as t…
jclapis 24a10c5
Testing removal of OpenSSL vendored option
jclapis e36da54
Updating just in the CI workflow
jclapis 843b110
Merge branch 'main' into cross-compile
jclapis e7c6d19
Refactored the signer to support host and port config settings
jclapis 6117219
Updated docs
jclapis c0f591d
Fixing Clippy in CI workflow
jclapis adbd34a
Removed obviated CI setup
jclapis e3488b3
Minor dedup of RwLock guard acquisition
jclapis c3d7ec4
Added rate limiting for signer clients with repeated JWT auth failures
jclapis 9ddad64
Added Signer config validation
jclapis c62185e
Started unit test setup for the Signer
jclapis dc73c62
Finished a basic signer module unit test
jclapis 6c3d967
Added a JWT failure unit test
jclapis 6464638
Added a rate limit test and cleaned up a bit
jclapis 0313f18
Added unique ports to unit tests for parallel execution
jclapis 346eea4
Cleaned up the build Dockerfile and removed an extra dependency layer
jclapis 7b20d2f
Ported the build script over to the justfile
jclapis cf3f0b1
Merge branch 'main' into cross-compile
jclapis ca9f4a1
Added a justfile recipe for installing protoc
jclapis 3eed526
Merge branch 'cross-compile' into add-ip-bind-to-signer
jclapis aa6ad96
Merge branch 'add-ip-bind-to-signer' into rate-limit-jwt
jclapis fc872ac
Merge branch 'main' into add-ip-bind-to-signer
jclapis ca0c6e8
Merge branch 'add-ip-bind-to-signer' into rate-limit-jwt
jclapis 612b072
Added chunked reading to some HTTP response handlers
jclapis 672aacf
Started putting together unit tests for the SSV key loader's HTTP han…
jclapis 40d34aa
Merge branch 'main' into add-ip-bind-to-signer
jclapis d537288
Update crates/cli/src/docker_init.rs
jclapis 7afb763
Added example signer config params
jclapis 09ac821
Cleaned up signer config loading from feedback
jclapis cf39d86
Merge remote-tracking branch 'origin/add-ip-bind-to-signer' into add-…
jclapis 2431937
Merge branch 'add-ip-bind-to-signer' into rate-limit-jwt
jclapis db7c915
Merge branch 'main' into improve-http-handling
jclapis cb7c8eb
Finished unit tests for the SSV loader
jclapis 2e1198b
Merge branch 'main' into rate-limit-jwt
jclapis dcf1b0f
Merge branch 'rate-limit-jwt' into improve-http-handling
jclapis adc4389
Ported HTTP timeout to the PBS event publisher
jclapis 37d299a
Added the http timeout to the example config
jclapis 5df487a
Fixed a test
jclapis ccaf97d
Added JWT auth fields to the example config
jclapis cc13a6f
Fixed some example config parameters
jclapis 9bacc9f
Merge branch 'main' into rate-limit-jwt
jclapis b9514df
Update crates/signer/src/service.rs
jclapis 05fd25a
Swapping to non-async RwLock based on feedback
jclapis efc7ac7
Merge branch 'rate-limit-jwt' of github.com:Commit-Boost/commit-boost…
jclapis 287587b
Merge branch 'rate-limit-jwt' into improve-http-handling
jclapis a30a8aa
Merge branch 'main' into improve-http-handling
jclapis cc7e87b
Removed HTTP_TIMEOUT_SECONDS_ENV
jclapis 0d1e395
Removed HTTPS restriction for the mux loader
jclapis fb7cc10
Moved scopeguard to dev-dependencies for cb-common
jclapis 9709e2a
Moved CB_TEST_HTTP_DISABLE_CONTENT_LENGTH_ENV
jclapis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anything used just for testing should go under
[dev-dependencies]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in fb7cc10, though I left the workspace file alone and just adjusted the cb-common package's cargo file.