Skip to content

Add machine-scope config hydration for OEM sysprep flows#1598

Draft
benceruleanlu wants to merge 14 commits intomainfrom
ben/oem-machine-scope-install-state
Draft

Add machine-scope config hydration for OEM sysprep flows#1598
benceruleanlu wants to merge 14 commits intomainfrom
ben/oem-machine-scope-install-state

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Feb 9, 2026

Summary

  • add Windows machine-scope config support rooted in ProgramData (machine-config.json)
  • hydrate missing per-user desktop config from machine-scoped config on first launch
  • persist machine-scope install metadata/state during install and state transitions
  • resolve model config path and default install path from machine scope when applicable
  • add installer CLI parsing and persistence for OEM options (/INSTALL_SCOPE, /ALLUSERS, /CURRENTUSER, /OEM, /BASE_PATH, /AUTO_UPDATE, /DISABLE_AUTO_UPDATE, /PRESEED_CONFIG_DIR)
  • add tests for machine config utilities and install-state hydration
  • add AMD OEM requirement verification/design doc

Validation

  • yarn lint
  • yarn typecheck
  • yarn test:unit tests/unit/config/machineConfig.test.ts tests/unit/main-process/comfyInstallation.test.ts tests/unit/config/comfyServerConfig.test.ts tests/unit/install/installationManager.test.ts

Notes

  • Confidential source artifacts are not included in this PR.

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ben/oem-machine-scope-install-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant