fix: force frontend sourcemaps in desktop builds#1570
fix: force frontend sourcemaps in desktop builds#1570benceruleanlu wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThis PR adds the Changes
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR ensures that frontend source builds for the desktop application explicitly enable sourcemap generation by setting GENERATE_SOURCEMAP=true as an environment variable during the build process. This allows Sentry to properly resolve stack traces from production builds even when release artifacts omit the source maps.
Changes:
- Added
GENERATE_SOURCEMAP: 'true'environment variable to the frontend build command when building from source
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Evidence CheckIf this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
Ensure desktop source builds explicitly set
GENERATE_SOURCEMAP=truewhen building the frontend so Sentry can resolve stack traces even if release zips omit maps.Tests:
yarn typecheck,yarn lint:check,yarn format,yarn lint┆Issue is synchronized with this Notion page by Unito
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.