fix: use module attributes to detect vendor directly#44
Open
lalala-233 wants to merge 2 commits into
Open
Conversation
Contributor
|
It seems that torch naming rules were changed starting with CUDA 13.2? So this fix should be applied to ComfyUI side as well. |
Author
|
I'm not sure if it is because I use Arch Linux. Arch Linux's official repo repackaged But I think using module attributes to directly detect vendor is not a bad idea :) I'll create a PR to ComfyUI later. |
Author
|
I found I repeated some useless code. I forgot to remove it after I copy it from my minimal test. Now there is no problem, I hope :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current vendor check relies on
version.py's__version__:comfy-aimdo/comfy_aimdo/control.py
Lines 12 to 31 in 604f355
However, in my PC,
__version__is2.11.0with no suffix, so this function returnsNone.But..
I can use cuda actually.
So I refactor
detect_rendorto use module attributes directly.But I haven't tested if it break anything in other's PC. It works well on my PC. Could someone help me test it?
Contribution Agreement