[bugfix] use raw template ID for workflow_name in telemetry tracking #6320
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed trackTemplate calls to use raw template ID instead of translated workflow name. This ensures workflow_name is consistently tracked in English regardless of user's locale setting. Before: workflow_name could be "默认工作流" (Chinese) After: workflow_name is always "default" (template ID) The translated name is still used for display purposes in loadGraphData.
christian-byrne
requested review from
Myestery and
comfyui-wiki
as code owners
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 10/27/2025, 04:26:04 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/27/2025, 04:09:49 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.29 MB (baseline 3.29 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 721 kB (baseline 721 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 8.15 kB (baseline 8.15 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…6320) ## Summary Fixes `trackTemplate` calls to use raw template ID instead of translated workflow name for analytics tracking. ## Problem When users load templates with non-English locale, the `workflow_name` field was being tracked in their language (e.g., "默认工作流" for Chinese users) instead of English. This makes statistical analysis difficult. ## Changes - Updated both `trackTemplate` calls in `useTemplateWorkflows.ts` to use raw `id` instead of translated `workflowName` - The translated name is still used for display purposes in `loadGraphData` **Before:** ```typescript useTelemetry()?.trackTemplate({ workflow_name: workflowName, // Could be "默认工作流" template_source: sourceModule }) ``` **After:** ```typescript useTelemetry()?.trackTemplate({ workflow_name: id, // Always "default" template_source: sourceModule }) ``` ## Testing - [x] Type checking passes - [x] Verified translated names still used for display ## Related Part of comprehensive i18n audit for telemetry tracking. Related to template metadata English tracking in PR #6304. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6320-bugfix-use-raw-template-ID-for-workflow_name-in-telemetry-tracking-2996d73d365081d8aef3fa2529a10247) by [Unito](https://www.unito.io)
|
@christian-byrne Successfully backported to #6324 |
christian-byrne
added a commit
that referenced
this pull request
Oct 27, 2025
…telemetry tracking (#6324) Backport of #6320 to `rh-test` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6324-backport-rh-test-bugfix-use-raw-template-ID-for-workflow_name-in-telemetry-tracking-2996d73d36508127be92f67e530989a7) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
trackTemplatecalls to use raw template ID instead of translated workflow name for analytics tracking.Problem
When users load templates with non-English locale, the
workflow_namefield was being tracked in their language (e.g., "默认工作流" for Chinese users) instead of English. This makes statistical analysis difficult.Changes
trackTemplatecalls inuseTemplateWorkflows.tsto use rawidinstead of translatedworkflowNameloadGraphDataBefore:
After:
Testing
Related
Part of comprehensive i18n audit for telemetry tracking. Related to template metadata English tracking in PR #6304.
┆Issue is synchronized with this Notion page by Unito