Speed: Remove some optimizations that weren't optimizing #6209
+3
−955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 10/29/2025, 12:37:01 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/29/2025, 12:22:47 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.3 MB (baseline 3.3 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 2 added / 2 removed Graph Workspace — 712 kB (baseline 716 kB) • 🟢 -3.86 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.15 kB (baseline 8.15 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
simula-r
reviewed
Oct 24, 2025
| cn( | ||
| 'absolute inset-0 w-full h-full pointer-events-none', | ||
| isInteracting ? 'transform-pane--interacting' : 'will-change-auto', | ||
| 'absolute inset-0 w-full h-full pointer-events-none will-change-auto', |
There was a problem hiding this comment.
IIRC transform-pane--interacting, will-change: transform which served 2 purposes:
- A browser hint to promote the layer to the compositor. Without will-change: transform what are we relying on to ensure promotion? Is the css transform declaration on the transform pane itself enough? https://webperf.tips/tip/layers-and-compositing/#when-are-layers-created
- The flip back to will-change: auto forced a reflow and subsequent paint which ensured at close zoom pixel stretch wouldn't be noticeable. @christian-byrne I remember earlier conversations where I was unsure if it was needed but found a few examples where without it, the node's text and borders were significantly stretched. Can we confirm this is not needed now?
| // Vue node system | ||
| const vueNodeLifecycle = useVueNodeLifecycle() | ||
| const { handleTransformUpdate } = useViewportCulling() |
There was a problem hiding this comment.
Viewport Culling was one of if not the most needle moving performance improvement to large workflows (removing nodes from the layout tree via display: none in order to shrink the layer bounds) from the performance dev tool flame graph traces I ran.
There was a problem hiding this comment.
I compared this branch with main (that has viewport culling) and in 300+ node large workflows when zoomed in helps the responsiveness by a considerable amount. What tests did you use to determine it was unnecessary?
There was a problem hiding this comment.
I tested with a workflow with 896 nodes and it was a lot smoother to both zoom and pan.
There was a problem hiding this comment.
This could definitely vary across OS/Browser/Browser settings.
DrJKL
force-pushed
the
drjkl/slap-it-on
branch
4 times, most recently
from
b92e640 to
5ac24b2
Compare
DrJKL
force-pushed
the
drjkl/slap-it-on
branch
from
5ac24b2 to
a1674af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the TransformPane.
Changes
Review Focus
In testing with a huge workflow in Vue mode, it was a lot faster without these than with.
Can you check to see if you experience the same benefits?
┆Issue is synchronized with this Notion page by Unito