feat: implement asset deletion functionality

[viva-jinyi]

Summary

• Implement asset deletion for media assets
• Add delete confirmation dialog
• Support both cloud and internal asset deletion
• Refresh assets list after successful deletion

Changes

• Add delete button to MediaAssetActions component
• Implement deleteAsset method in useMediaAssetActions
• Add confirmation dialog before deletion
• Handle asset-deleted event to refresh the list
• Refactor to use QueueStore.tasks for proper grouping

Test plan

• Delete output assets in internal mode
• Delete input/output assets in cloud mode
• Verify confirmation dialog appears
• Check assets list refreshes after deletion
• Test folder view functionality

screen-capture.3.webm

[github-actions]

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/27/2025, 11:58:51 AM UTC

📈 Summary

• Total Tests: 498
• Passed: 464 ✅
• Failed: 0
• Flaky: 3 ⚠️
• Skipped: 31 ⏭️

📊 Test Reports by Browser

• ✅ chromium: View Report • ✅ 455 / ❌ 0 / ⚠️ 3 / ⏭️ 31
• ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

---

🎉 Click on the links above to view detailed test results for each browser configuration.

[claude]

Comprehensive PR Review

This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another.

Review Summary

PR: feat: implement asset deletion functionality (#6203)
Impact: 185 additions, 19 deletions across 7 files

Issue Distribution

• Critical: 0
• High: 2
• Medium: 7
• Low: 1

Category Breakdown

• Architecture: 2 issues
• Security: 0 issues
• Performance: 1 issue
• Code Quality: 7 issues

Key Findings

Architecture & Design

The PR successfully implements a comprehensive asset deletion system that handles both cloud and desktop environments appropriately. However, there are some architectural concerns:

• Function signature changes: The deleteAsset function now returns boolean success indicators, but not all calling patterns may handle this properly
• Error handling patterns: Mix of exception throwing and return value patterns could lead to inconsistent error handling

Security Considerations

No significant security vulnerabilities identified. The implementation correctly:

• Validates environment context before allowing input file deletion
• Uses proper API endpoints for asset deletion
• Maintains appropriate permission boundaries between cloud and desktop modes

Performance Impact

The implementation includes proper async operations with store updates, but could benefit from:

• Loading state indicators during potentially long-running operations
• Optimistic updates with rollback to improve perceived performance

Integration Points

Good integration with existing systems:

• Proper use of dialog system for confirmation
• Correct store update patterns after deletion
• Event-driven architecture with asset-deleted events

Positive Observations

• Comprehensive deletion logic: Handles different asset types appropriately (input vs output)
• Environment awareness: Correctly restricts input file deletion to cloud environments
• User experience: Adds confirmation dialogs and proper success/error feedback
• Event-driven design: Uses proper event emission for UI updates
• Translation integration: Attempts to use i18n system (though with some inconsistencies)

References

• Repository Architecture Guide
• Frontend Standards
• Security Guidelines

Next Steps

1. Address high priority issues around error handling before merge
2. Standardize i18n usage for all user-facing strings
3. Consider adding loading states for better UX
4. Remove unreachable code and improve null safety

---

This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review.

[benceruleanlu]

how come we don't support deleting local output assets yet? the delete button isn't gated for cloud so it might be confusing for users to have different experiences

[benceruleanlu]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[christian-byrne]

On local, it's not really deleting right? Just removing that task from the history - but the underlying asset is still in ComfyUI/output

[viva-jinyi]

Yes, it only deletes from history. On local environments, we're only removing the task from the execution history, not deleting the actual files from the filesystem.