Show workflow templates from custom nodes #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show selection list for custom_nodes that contain workflow templates - Put item cards in carousel - Use getWorkflowTemplates() to fetch items
This comment was marked as resolved.
This comment was marked as resolved.
huchenlei
suggested changes
Dec 28, 2024
| <div | ||
| v-for="template in templates" | ||
| :key="template" | ||
| :data-testid="`template-workflow-${template}`" |
There was a problem hiding this comment.
Please keep the data-testid for playwright test.
| ws: true | ||
| }, | ||
|
|
||
| '/workflow_templates': { |
There was a problem hiding this comment.
Please revert unrelated format changes.
| background-color: var(--comfy-menu-secondary-bg); | ||
| color: var(--fg-color); | ||
| font-family: primeicons, sans-serif; | ||
| content: '\e958'; /* Document icon from primevue */ |
There was a problem hiding this comment.
Let's use a less hacky way to implement fallback placeholder.
| const json = await fetch(api.fileURL(`templates/${id}.json`)).then((r) => | ||
| r.json() | ||
| ) | ||
| let json |
There was a problem hiding this comment.
Let's extract the storage of custom nodes workflow templates as a Pinia store to avoid reloading everytime the dialog is opened.
| <div class="flex items-center justify-center"> | ||
| <div | ||
| class="absolute top-0 left-0 w-64 h-64 overflow-hidden opacity-0 transition duration-300 ease-in-out hover:opacity-100 bg-opacity-50 bg-black flex items-center justify-center" | ||
| class="relative overflow-hidden rounded-lg cursor-pointer w-64 h-64" |
There was a problem hiding this comment.
The template workflow item here should probably be extracted as a separated Vue component.
| :key="template" | ||
| :data-testid="`template-workflow-${template}`" | ||
| <div class="flex h-96"> | ||
| <Listbox |
There was a problem hiding this comment.
Listbox allows null value on v-model:modeValue. Currently deselect item on that listbox will cause error.
huchenlei
approved these changes
Dec 30, 2024
viva-jinyi
added a commit
that referenced
this pull request
Jul 27, 2025
Use collectAllNodes to recursively scan subgraphs for missing custom nodes. Fixes #2032
4 tasks
viva-jinyi
added a commit
that referenced
this pull request
Jul 27, 2025
Use collectAllNodes to recursively scan subgraphs for missing custom nodes. Fixes #2032
viva-jinyi
added a commit
that referenced
this pull request
Jul 28, 2025
Use collectAllNodes to recursively scan subgraphs for missing custom nodes. Fixes #2032
viva-jinyi
added a commit
that referenced
this pull request
Jul 29, 2025
Use collectAllNodes to recursively scan subgraphs for missing custom nodes. Fixes #2032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008 feature request.
Requires the following backend PR: comfyanonymous/ComfyUI#6193 (merged)
Implementation details:
┆Issue is synchronized with this Notion page by Unito