Change the save 3d model node's filename prefix to 3d/ComfyUI#12826
Change the save 3d model node's filename prefix to 3d/ComfyUI#12826comfyui-wiki wants to merge 2 commits intoComfy-Org:masterfrom
save 3d model node's filename prefix to 3d/ComfyUI#12826Conversation
As this node has already changed from `Save GLB` to `Save 3D Model`, using the filename prefix `3d` will be better than `mesh`
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn comfy_extras/nodes_hunyuan3d.py the SaveGLB.define_schema default for the 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@comfy_extras/nodes_hunyuan3d.py`:
- Line 640: The default filename prefix uses uppercase "3D/ComfyUI" which
conflicts with the rest of the file's lowercase "3d" category; change the
IO.String.Input default for "filename_prefix" (the call
IO.String.Input("filename_prefix", default="3D/ComfyUI")) to "3d/ComfyUI" so it
matches other category values and avoids case-sensitive filesystem mismatches.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c14961e3-e71f-460a-84eb-c14252156c28
📒 Files selected for processing (1)
comfy_extras/nodes_hunyuan3d.py
As this node has already changed from
Save GLBtoSave 3D Model, using the filename prefix3dwill be better thanmesh