Skip to content

Change the save 3d model node's filename prefix to 3d/ComfyUI#12826

Open
comfyui-wiki wants to merge 2 commits intoComfy-Org:masterfrom
comfyui-wiki:comfyui-wiki-patch-2
Open

Change the save 3d model node's filename prefix to 3d/ComfyUI#12826
comfyui-wiki wants to merge 2 commits intoComfy-Org:masterfrom
comfyui-wiki:comfyui-wiki-patch-2

Conversation

@comfyui-wiki
Copy link
Member

As this node has already changed from Save GLB to Save 3D Model, using the filename prefix 3d will be better than mesh

As this node has already changed from `Save GLB` to `Save 3D Model`, using the filename prefix `3d` will be better than `mesh`
@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bc6ab205-c37e-4e2d-b1b5-5f7518454bc3

📥 Commits

Reviewing files that changed from the base of the PR and between 3f2b698 and 6bc7be0.

📒 Files selected for processing (1)
  • comfy_extras/nodes_hunyuan3d.py

📝 Walkthrough

Walkthrough

In comfy_extras/nodes_hunyuan3d.py the SaveGLB.define_schema default for the filename_prefix input was changed from "mesh/ComfyUI" to "3d/ComfyUI". This alters only the default subfolder used for saved GLB outputs; no function signatures or processing logic were modified.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the filename prefix for the Save 3D Model node from 'mesh' to '3d/ComfyUI'.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for changing the prefix from 'mesh' to '3d' based on the node's name change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@comfy_extras/nodes_hunyuan3d.py`:
- Line 640: The default filename prefix uses uppercase "3D/ComfyUI" which
conflicts with the rest of the file's lowercase "3d" category; change the
IO.String.Input default for "filename_prefix" (the call
IO.String.Input("filename_prefix", default="3D/ComfyUI")) to "3d/ComfyUI" so it
matches other category values and avoids case-sensitive filesystem mismatches.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c14961e3-e71f-460a-84eb-c14252156c28

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac8152 and 3f2b698.

📒 Files selected for processing (1)
  • comfy_extras/nodes_hunyuan3d.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant