Closed
Conversation
* align design of default and semantic button variants * Default alignment for ButtonToolbars * Enforce square icons in Buttons, enforce square proportions for icon-only buttons * Add title values and aria-labels to SelectionActions * Introduce ElementIcon to retrieve standard icons for different element types * Create a clone of DetailCard to incrementally roll out a new version * Introduce new DetailCard migrate ReportDetails and LiteratureDetails * Migrate SampleDetails to new DetailCard * Simplify copy functionality for DetailCard * Style consolidation * Add dedicated title tooltip functionality * Split up DetailCard and ElementDetailCard to use specific functionality only where it applies. * Standardise Calendar and Barcode Button behaviour in ElementDetailCard * Migrate WellplateDetails to ElementDetailCard integrate more standard function into ElementDetailCard * Migrate ScreenDetails to ElementDetailCard * Migrate ResearchPlanDetails to ElementDetailCard * Migrate CellLineDetails to ElementDetailCard * Migrate DeviceDescriptionDetails to ElementDetailCard * Migrate SequenceBasedMacromoleculeSampleDetails to ElementDetailCard * Fix file formatting for SequenceBasedMacromoleculeSampleDetails * Migrate GenericElDetails to ElementDetailCard * Migrate GraphContainer to new DetailCard * Migrate ComputeTaskContainer to new DetailCard * Rename FormatComponent to FormatDetails, fixed linting issues * Migrate FormatDetails to new DetailCard * Inline MetadataHeader into MetadatContainer * Migrate MetadataContainer to new DetailCard * Removed DetailCard from VesselProperties – DetailCards should not be nested * Migrate VesselCards to new DetailCard * use button states in unit InputGroups consistently * Style ElementCollectionLabels * Style HeaderCommentSection * center reaction graphic in ReactionGroupHeader * Remove "Ontology" from form Label "Type (Name Reaction Ontology)" * Change button label for SelectionGenerateButton * Make SupportMenuButton readable on login and admin pages * fix: report, reference details close button param to Detailcard * fix: check selecteds + keys combo before creating report, literature_map tabs * Change breakpoint for SelectionActions to accommodate current content * Redesign and reposition CreateElementButton * Make PrintCodeButton smaller in analyses tabs * Align popover headers with current design * Restore file location of the uniprot logo as intended in cb7f115 * fix expectedHtml in unit test * Reconstruct incomplete VesselDetails functionality. Try to fix unit test. * remove link around chemotion logo * Keep CreateElementButton in viewport for narrow elements columns
LCOV of commit
|
LCOV of commit
|
ElementDetailCard ignored the onSaveClose callback passed by element details (SampleDetails, ReactionDetails), causing the save-and-close button to save without closing the panel. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
LCOV of commit
|
JoachimTillessen
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of #3063