Skip to content

scss fix for build #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZaidPathan wants to merge 1 commit into
base: v3
Choose a base branch
from
+3 −5
Open

scss fix for build #5715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions build/scss/mixins/_toasts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@

// Toast Variant
@mixin toast-variant($name, $color) {
&.bg-#{$name} {
background-color: rgba($color, .9) !important;
#{if(&, '&.bg-#{$name}','.bg-#{$name}')} {
background-color: rgba($color, 0.9) !important;
Comment on lines +7 to +8
Copy link

@theneonstark theneonstark Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your part attempts to use a conditional to check if the current selector is & and the syntax here is incorrect and might not achieve your intended outcome.

@if (color-yiq($color) == $yiq-text-light) {

.close {
color: color-yiq($color);
text-shadow: 0 1px 0 $black;
}
}

.toast-header {
background-color: rgba($color, .85);
background-color: rgba($color, 0.85);
Copy link

@theneonstark theneonstark Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this gonna be right but no matter use .85 or 0.85 because SCSS detect the same for this

color: color-yiq($color);
}
}
}